Skip to content

FIX: Fixing 4 broken notebooks#2182

Merged
rlundeen2 merged 1 commit into
microsoft:mainfrom
rlundeen2:rlundeen2-fix-failing-integration-tests
Jul 13, 2026
Merged

FIX: Fixing 4 broken notebooks#2182
rlundeen2 merged 1 commit into
microsoft:mainfrom
rlundeen2:rlundeen2-fix-failing-integration-tests

Conversation

@rlundeen2

Copy link
Copy Markdown
Contributor

Fixes broken doc notebooks that fail the integration notebook-execution tests because they lag current PyRIT APIs.

Fixed (deterministic API mismatches, validated by running each notebook end-to-end)

  • 0_scenarios: pass typed RegisteredScenario items to print_scenario_list instead of .model_dump() dicts (it expects attribute access).
  • 2_custom_scenario_parameters: drop .model_dump() and filter the typed items directly.
  • 6_custom_targets: AttackAdversarialConfig now takes first_message (the removed seed_prompt).

Not included

  • 3_adaptive_scenarios: a separate, deterministic CI-only failure (Missing required keys {'last_response_summary'} from the adversarial chat). Root cause is adversarial structured-output enforcement / deployment config, not stale notebook code — still under investigation and tracked separately.

Update three doc notebooks to match current PyRIT APIs so the integration
notebook-execution tests pass:

- 0_scenarios: pass typed RegisteredScenario items to print_scenario_list
  instead of .model_dump() dicts (print_scenario_list expects attribute access).
- 2_custom_scenario_parameters: drop .model_dump() and filter typed items directly.
- 6_custom_targets: AttackAdversarialConfig uses first_message (seed_prompt removed).

The fourth failing notebook (3_adaptive_scenarios) is a separate, deterministic
CI-only failure tied to adversarial structured-output enforcement and is still
under investigation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f10902e3-c95a-4c2a-b17c-0a4f3fd46b5e
@jsong468 jsong468 self-assigned this Jul 13, 2026
@rlundeen2 rlundeen2 enabled auto-merge July 13, 2026 22:49
@rlundeen2 rlundeen2 added this pull request to the merge queue Jul 13, 2026
Merged via the queue into microsoft:main with commit 3ce657b Jul 13, 2026
53 checks passed
@rlundeen2 rlundeen2 deleted the rlundeen2-fix-failing-integration-tests branch July 13, 2026 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants